Sparse global order reader: fix tile cleanup when ending an iteration. #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the tile cleanup code when an iteration is done. When the user sets ranges, the first tile for a fragment might not have index 0. The tile index in the read state (initialized at 0) for a fragment might not be touched if an iteration doesn't merge any cells from that fragment, so it might stay 0. As the cleanup code was looking for an exact match on the tile index before stopping cleanup, this would clean up every tiles. The cleanup now cleans up tiles with an index smaller than the index in the read state which fixes this case. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: fix tile cleanup when ending an iteration.
johnkerl
approved these changes
Nov 22, 2022
ihnorton
approved these changes
Nov 22, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
#3674) This change fixes the tile cleanup code when an iteration is done. When the user sets ranges, the first tile for a fragment might not have index 0. The tile index in the read state (initialized at 0) for a fragment might not be touched if an iteration doesn't merge any cells from that fragment, so it might stay 0. As the cleanup code was looking for an exact match on the tile index before stopping cleanup, this would clean up every tiles. The cleanup now cleans up tiles with an index smaller than the index in the read state which fixes this case. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: fix tile cleanup when ending an iteration.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
#3674) This change fixes the tile cleanup code when an iteration is done. When the user sets ranges, the first tile for a fragment might not have index 0. The tile index in the read state (initialized at 0) for a fragment might not be touched if an iteration doesn't merge any cells from that fragment, so it might stay 0. As the cleanup code was looking for an exact match on the tile index before stopping cleanup, this would clean up every tiles. The cleanup now cleans up tiles with an index smaller than the index in the read state which fixes this case. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: fix tile cleanup when ending an iteration.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
#3674) This change fixes the tile cleanup code when an iteration is done. When the user sets ranges, the first tile for a fragment might not have index 0. The tile index in the read state (initialized at 0) for a fragment might not be touched if an iteration doesn't merge any cells from that fragment, so it might stay 0. As the cleanup code was looking for an exact match on the tile index before stopping cleanup, this would clean up every tiles. The cleanup now cleans up tiles with an index smaller than the index in the read state which fixes this case. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: fix tile cleanup when ending an iteration.
Shelnutt2
pushed a commit
that referenced
this pull request
Nov 22, 2022
#3674) (#3676) This change fixes the tile cleanup code when an iteration is done. When the user sets ranges, the first tile for a fragment might not have index 0. The tile index in the read state (initialized at 0) for a fragment might not be touched if an iteration doesn't merge any cells from that fragment, so it might stay 0. As the cleanup code was looking for an exact match on the tile index before stopping cleanup, this would clean up every tiles. The cleanup now cleans up tiles with an index smaller than the index in the read state which fixes this case. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: fix tile cleanup when ending an iteration. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
Shelnutt2
pushed a commit
that referenced
this pull request
Nov 22, 2022
#3674) (#3677) This change fixes the tile cleanup code when an iteration is done. When the user sets ranges, the first tile for a fragment might not have index 0. The tile index in the read state (initialized at 0) for a fragment might not be touched if an iteration doesn't merge any cells from that fragment, so it might stay 0. As the cleanup code was looking for an exact match on the tile index before stopping cleanup, this would clean up every tiles. The cleanup now cleans up tiles with an index smaller than the index in the read state which fixes this case. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: fix tile cleanup when ending an iteration. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
Shelnutt2
pushed a commit
that referenced
this pull request
Nov 22, 2022
#3674) (#3678) This change fixes the tile cleanup code when an iteration is done. When the user sets ranges, the first tile for a fragment might not have index 0. The tile index in the read state (initialized at 0) for a fragment might not be touched if an iteration doesn't merge any cells from that fragment, so it might stay 0. As the cleanup code was looking for an exact match on the tile index before stopping cleanup, this would clean up every tiles. The cleanup now cleans up tiles with an index smaller than the index in the read state which fixes this case. --- TYPE: IMPROVEMENT DESC: Sparse global order reader: fix tile cleanup when ending an iteration. Co-authored-by: KiterLuc <67824247+KiterLuc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the tile cleanup code when an iteration is done. When the user sets ranges, the first tile for a fragment might not have index 0. The tile index in the read state (initialized at 0) for a fragment might not be touched if an iteration doesn't merge any cells from that fragment, so it might stay 0. As the cleanup code was looking for an exact match on the tile index before stopping cleanup, this would clean up every tiles. The cleanup now cleans up tiles with an index smaller than the index in the read state which fixes this case.
TYPE: IMPROVEMENT
DESC: Sparse global order reader: fix tile cleanup when ending an iteration.