[Backport release-2.23] Add array uri to tiledb_array_deserialize #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
[sc-47129 ](https://app.shortcut.com/tiledb-inc/story/47129/add-array-uri-to-tiledb-array-deserialize ) Today `tiledb_array_deserialize` is using a hardcoded uri name (`"deserialized_array"`) , whereas `tiledb_deserialize_query_and_array` is requiring the actual `array_uri` as an argument. The former is problematic for wrapping those calls in python, so this ticket is aiming to unify the two to both receive the `array_uri` as input. (history on why this is needed here: https://app.shortcut.com/tiledb-inc/story/47139/investigate-if-core-serialization-apis-could-be-used-externally-to-pass-cache-open-arrays) There's no backward compatibility issue here as this is a deserialization function only called by REST Server, so we don't need to keep both versions of `tiledb_array_deserialize`. That said, the REST-CI tests that run based on latest dev on Core and latest master in Cloud-REST will break after this change. We will handle this by adapting the REST-CI script to patch temporarily Cloud-REST master with the needed change and remove when 2.24 is released TileDB-Inc/TileDB-Internal#27 . Another idea was to maintain both flavors until the release is ready to go out and then remove but C doesn't support overloading functions. Future work to track: #4961 --- TYPE: IMPROVEMENT DESC: Add array uri to tiledb_array_deserialize
KiterLuc
force-pushed
the
backport-4961-to-release-2.23
branch
from
a58edf5
to
6465f0a
Compare
KiterLuc
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 69028d8 from #4961.
TYPE: IMPROVEMENT
DESC: Add array uri to tiledb_array_deserialize