Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-2.23] Add array uri to tiledb_array_deserialize #5109

Merged
merged 2 commits into from
Jun 19, 2024
Merged

[Backport release-2.23] Add array uri to tiledb_array_deserialize #5109

merged 2 commits into from
Jun 19, 2024

Commits on Jun 19, 2024

  1. Add array uri to tiledb_array_deserialize (#4961) 

    [sc-47129

](https://app.shortcut.com/tiledb-inc/story/47129/add-array-uri-to-tiledb-array-deserialize
)
Today `tiledb_array_deserialize` is using a hardcoded uri name
(`"deserialized_array"`) , whereas `tiledb_deserialize_query_and_array`
is requiring the actual `array_uri` as an argument. The former is
problematic for wrapping those calls in python, so this ticket is aiming
to unify the two to both receive the `array_uri` as input. (history on
why this is needed here:
https://app.shortcut.com/tiledb-inc/story/47139/investigate-if-core-serialization-apis-could-be-used-externally-to-pass-cache-open-arrays)

There's no backward compatibility issue here as this is a
deserialization function only called by REST Server, so we don't need to
keep both versions of `tiledb_array_deserialize`.

That said, the REST-CI tests that run based on latest dev on Core and
latest master in Cloud-REST will break after this change. We will handle
this by adapting the REST-CI script to patch temporarily Cloud-REST
master with the needed change and remove when 2.24 is released
TileDB-Inc/TileDB-Internal#27 . Another idea was
to maintain both flavors until the release is ready to go out and then
remove but C doesn't support overloading functions.

Future work to track:  #4961

---
TYPE: IMPROVEMENT
DESC: Add array uri to tiledb_array_deserialize
    @ypatia @KiterLuc
    ypatia authored and KiterLuc committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    6465f0a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'release-2.23' into backport-4961-to-release-2.23

    @KiterLuc
    KiterLuc committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    8a9ad8c View commit details
    Browse the repository at this point in the history