Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nighly feedstock build failed #86

Closed
github-actions bot opened this issue Apr 11, 2024 · 11 comments · Fixed by #87
Closed

Nighly feedstock build failed #86

github-actions bot opened this issue Apr 11, 2024 · 11 comments · Fixed by #87

Comments

@github-actions
Copy link

Nightly feedstock build failure for tiledbfeedstock_CI at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=4&_a=summary

Copy link
Author

Nightly feedstock build failure for TileDB-Py%20Feedstock%20Testing at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=5&_a=summary

@jdblischak
Copy link
Collaborator

The win-64 tiledb-feedstock build failed

Getting pinned dependencies: ...working... failed
WARNING: failed to get package records, retrying.  exception was: Unsatisfiable dependencies for platform win-64: {MatchSpec("vs_win-64==2019.11=he1865b1_12")}
Encountered problems while solving:
  - package vs2022_win-64-19.33.31629-hc4b314a_8 has constraint vs_win-64 2022.* conflicting with vs_win-64-2019.11-he1865b1_12

Restarted first before investigating further

@jdblischak
Copy link
Collaborator

Confirmed the problem persists even after a restart. I believe this is related to how 2.22 requires vs2022 (conda-forge/tiledb-feedstock#268, #69, #74, TileDB-Inc/TileDB#4759)

But what changed recently? My guess is that the problem is due to the rerendering from conda-forge/tiledb-feedstock#271 that added {{ stdlib("c") }} to the build requirements

@KiterLuc
Copy link
Contributor

@teo-tsirpanis any ideas?

@KiterLuc KiterLuc reopened this Apr 11, 2024
@jdblischak
Copy link
Collaborator

This is a conda problem. I think we'll need to change the keywords we use in conda_build_config.yaml to additionally control stdlib("c")

@jdblischak
Copy link
Collaborator

The failure is related to the current migration to pin the version of the C standard library (conda-forge/conda-forge.github.io#2102). Furthermore there are some ongoing fixes related to Windows that were identified earlier this week (conda-forge/conda-forge-repodata-patches-feedstock#701, conda-forge/vc-feedstock#75, conda-forge/conda-forge-pinning-feedstock#5736).

Given that this is clearly a conda-forge ecoystem issue, and not at all related to any recent change to TileDB, I'm going to let this sit until tomorrow. I don't want to spin our wheels while repodata patches etc. are taking their effect.

@h-vetinari
Copy link

h-vetinari commented Apr 11, 2024

The problem is that the c_stdlib_version now enforces a version, which itself was due to an issue with the vs-setup that now got fixed. Strictly speaking we should be able to revert the former fix, though for now, the solution is to match the c_stdlib_version to your compiler version, i.e., add:

c_stdlib_version:    # [win]
  - 2022             # [win]

to conda_build_config.yaml.

Copy link
Author

Nightly feedstock build failure for tiledbfeedstock_CI at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=4&_a=summary

Copy link
Author

Nightly feedstock build failure for TileDB-Py%20Feedstock%20Testing at https://dev.azure.com/TileDB-Inc/CI/_build?definitionId=5&_a=summary

@jdblischak
Copy link
Collaborator

though for now, the solution is to match the c_stdlib_version to your compiler version, i.e., add:

@h-vetinari thanks! I confirmed this fixes the win-64 build and have opened PR #87 to update our nightly builds

Strictly speaking we should be able to revert the former fix

Does this mean that once conda-forge/conda-forge-pinning-feedstock#5756 and conda-forge/vc-feedstock#75 are merged, we will no longer have to manually pin c_stdlib_version when pinning c_compiler and cxx_compiler in conda_build_config.yaml?

@h-vetinari
Copy link

Does this mean that once conda-forge/conda-forge-pinning-feedstock#5756 and conda-forge/vc-feedstock#75 are merged, we will no longer have to manually pin c_stdlib_version when pinning c_compiler and cxx_compiler in conda_build_config.yaml?

That's the idea, yes. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants