Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do list for 2.22 release #268

Closed
8 tasks done
jdblischak opened this issue Mar 26, 2024 · 6 comments · Fixed by #275
Closed
8 tasks done

To-do list for 2.22 release #268

jdblischak opened this issue Mar 26, 2024 · 6 comments · Fixed by #275
Assignees

Comments

@jdblischak
Copy link
Member

jdblischak commented Mar 26, 2024

Comment:

There are multiple to-do items prior to merging the 2.22 release when it arrives. I am planning on taking care of them, but I am documenting them all here in case someone else is eager and wants to get the update PR merged ASAP.

  • Backport migrations to 2.21 release
    • Create a new branch 2.21.x
    • Rerender (only bump build number if a pin in .ci_support/ has changed)
    • Add 2.21.x to abi_migration_branches in conda-forge.yml (this should be done in the update PR itself since this needs to land in "main" to take effect)
  • Update MSVC to vs2022 for the win-64 build
  • Add azure-identity-cpp
    • Add azure-identity-cpp to host requirements
    • Add empty overlay port to tiledb-patches/

More details below:

Backport migrations

This is something we need to start doing for every release in order to continue supporting software downstream of libtiledb. What happens is we bump the minor release here in tiledb-feedstock, so the automated conda-forge migrations only get applied to the latest release. Then when a downstream client (eg libtiledbvcf or libtiledbsoma) tries to release a patch release, the conda solver fails because the version of libtiledb it builds against hasn't received the latest migrations.

xref: #247, #260

azure-identity-cpp

This is a new requirement for tiledb 2.22. However, now that we've started using vcpkg for the build, we need to also add an empty overlay port so that the build uses the conda-installed version of azure-identity-cpp.

xref: #242, TileDB-Inc/TileDB#4126, TileDB-Inc/conda-forge-nightly-controller#71

vs2022

conda-forge feedstocks build with vs2019 by default. This no longer works for tiledb 2.22, so we need to manually specify the build to use vs2022. Note that it's my understanding that this will require bumping the compiler to vs2022 for all downstream clients as well

xref: TileDB-Inc/conda-forge-nightly-controller#69, TileDB-Inc/conda-forge-nightly-controller#74, TileDB-Inc/TileDB#4759

@jdblischak
Copy link
Member Author

2.22 was just released https://github.com/TileDB-Inc/TileDB/releases/tag/2.22.0

Reminder that there are various updates we need to make to the recipe/feedstock for this release

cc @KiterLuc

@KiterLuc
Copy link
Contributor

cc @teo-tsirpanis

@jdblischak jdblischak mentioned this issue Apr 16, 2024
3 tasks
@johnkerl
Copy link

[sc-44519]

@jdblischak
Copy link
Member Author

I created the branch 2.21.x, rerendered locally, and pushed

https://github.com/conda-forge/tiledb-feedstock/tree/2.21.x

@jdblischak
Copy link
Member Author

@teo-tsirpanis added azure-identity-cpp in a89d116

@jdblischak
Copy link
Member Author

I added 2.21.x to the backport migrations list in 81612b6

I set the win-64 compiler to vs2022 in c1837f8 (and subsequently rerendered for the pin to propagate to the .ci_support/ file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants