Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vs2022 for windows builds #74

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Use vs2022 for windows builds #74

merged 1 commit into from
Mar 26, 2024

Conversation

dudoslav
Copy link
Contributor

Use vs2022 in windows builds

Copy link
Contributor

@KiterLuc KiterLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just making sure we don't accidentally merge before we figure out the downstream dependencies issue.

@jdblischak
Copy link
Collaborator

Thanks @dudoslav! I confirmed locally that the conda_build_config.yaml was edited as expected:

bash run-local-tiledb.sh

cat tiledb-feedstock/recipe/conda_build_config.yaml
## c_compiler:    # [win]
##   - vs2022       # [win]
## cxx_compiler:  # [win]
##   - vs2022       # [win]
## channel_sources:
##   - tiledb/label/nightlies,conda-forge
## channel_targets:
##   - tiledb nightlies

@jdblischak
Copy link
Collaborator

Just making sure we don't accidentally merge before we figure out the downstream dependencies issue.

@KiterLuc This PR will only affect the nightly builds on our TileDB-Inc feedstock fork. Thus we are free to experiment without affecting the conda-forge ecosystem or any actual users.

I want to merge this so we can determine if this is the fix we need. If it indeed fixes the problem, then we'll know we need to start mobilizing to push the migration to vs2022 (at minimum for our universe of tiledb packages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants