Depend on core >= 2.15.2, < 2.16 #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkerl
requested review from
gspowley,
jdblischak,
mlin and
Shelnutt2
as code owners
Shelnutt2
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Pinning needs to have an upperbound to prevent bringing in 2.16 or newer. Something like tiledb >=2.15.1,<2.16 (taken from https://github.com/conda-forge/tiledb-py-feedstock/blob/f153315c81da2ed5f2d89a968c94892aca4b0bde/recipe/meta.yaml#L35)
|
Since you are changing the recipe but not the package version, now is when you bump the build number from |
|
@jdblischak @Shelnutt2 thank you both for teaching me things! That said, I'm going to hold off b/c TileDB-Py 0.21.3 with core 2.15.2 is just around the corner: |
johnkerl
force-pushed
the
kerl/tiledb-py-0.21.2
branch
3 times, most recently
from
67db962
to
02ce0ca
Compare
johnkerl
force-pushed
the
kerl/tiledb-py-0.21.2
branch
from
02ce0ca
to
0227e17
Compare
|
Folding this into #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in single-cell-data/TileDB-SOMA#1296 and single-cell-data/TileDB-SOMA#1303, for the same reasons already narrated there.