Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-release test for TileDB-SOMA 1.2.3 #18

Closed
wants to merge 6 commits into from
Closed

Conversation

johnkerl
Copy link
Contributor

@johnkerl johnkerl commented May 2, 2023

Not to be merged. Just a check for "is the putative TileDB-SOMA 1.2.3 Conda-CI green?".

@johnkerl
Copy link
Contributor Author

johnkerl commented May 2, 2023

@jdblischak
Copy link
Collaborator

I don't think it's related to the test changes in this PR. I just synced "main" on my fork of the feedstock, and it failed with the same error

https://github.com/jdblischak/tiledbsoma-feedstock/tree/bb3fbeb622d88809cf20bc8b58c3a480803334c7
https://dev.azure.com/jdblischak/feedstock-builds/_build/results?buildId=248&view=results

@jdblischak
Copy link
Collaborator

I'm having trouble reproducing the solver error locally on Ubuntu. In the CI builds, libtiledbsoma builds fine, but then fails to solve the env once it tries to build the Python client:

mamba create --dry-run -n test-soma \
  --override-channels -c conda-forge -c tiledb \
  libtiledbsoma=1.2.2=h25619bb_0
##   + libtiledbsoma           1.2.2  h25619bb_0        tiledb/linux-64           246kB
##   + tiledb                 2.15.2  heaeb544_0        conda-forge/linux-64        6MB

mamba create --dry-run -n test-soma \
  --override-channels -c conda-forge -c tiledb \
  libtiledbsoma=1.2.2=h25619bb_0 \
  python=3.10 \
  tiledb-py \
  tiledbsoma-py
##   + libtiledbsoma              1.2.2  h25619bb_0               tiledb/linux-64           246kB
##   + tiledb                    2.15.2  heaeb544_0               conda-forge/linux-64        6MB
##   + tiledb-py                 0.21.3  py310hf537494_0          conda-forge/linux-64        1MB
##   + tiledbsoma-py              1.2.2  py310h40e830b_0          tiledb/linux-64           278kB

@johnkerl johnkerl changed the title Pre-release canary for TileDB-SOMA 1.2.3 Pre-release test for TileDB-SOMA 1.2.3 May 2, 2023
@johnkerl johnkerl closed this May 3, 2023
@johnkerl johnkerl reopened this May 3, 2023
@johnkerl
Copy link
Contributor Author

johnkerl commented May 3, 2023

Close/reopen to re-trigger CI

@johnkerl
Copy link
Contributor Author

johnkerl commented May 3, 2023

Pre-release green CI verified; closing as intended.

@johnkerl johnkerl closed this May 3, 2023
@jdblischak
Copy link
Collaborator

The nightly binaries from #19 have already been uploaded, so you could even locally install the latest version built from "main"

https://anaconda.org/tiledb/libtiledbsoma/files?channel=nightlies
https://anaconda.org/tiledb/tiledbsoma-py/files?channel=nightlies

You can install them locally by running the following:

mamba create -n soma-nightly --override-channels \
  -c conda-forge -c "tiledb/label/nightlies" -c tiledb \
  tiledbsoma-py="*20230503"
conda activate soma-nightly
conda list soma
## libtiledbsoma             1.2.2.dev20230503      hc1eed26_0    tiledb/label/nightlies
## somacore                  1.0.0              pyh4471522_1    tiledb
## tiledbsoma-py             1.2.2.dev20230503 py310h7717f27_0    tiledb/label/nightlies
python -c "import tiledbsoma; print(tiledbsoma.pytiledbsoma.version())"
## libtiledb=2.15.2

@johnkerl
Copy link
Contributor Author

johnkerl commented May 3, 2023

Actually there was contentful stuff on here -- this PR was conflating two things:

@Shelnutt2 @jdblischak would it be better to re-open #17 and get it merged, then do the 1.2.3 release per se? Or, would it be better to fold the #17 content into the (upcoming) actually-release-1.2.3 PR?

@jdblischak
Copy link
Collaborator

would it be better to re-open #17 and get it merged, then do the 1.2.3 release per se?

If the updated version restriction applies to 1.2.2, then I think it makes sense to merge that first (just bump the build number), and then later update to 1.2.3 (and return the build number to 0).

@johnkerl
Copy link
Contributor Author

johnkerl commented May 3, 2023

Ah of course @jdblischak ; I should have looked at it that way.

The restriction on TileDB core >=2.15.2 and TileDB-Py >= 0.21.3 is specifically for TileDB-SOMA 1.2.3. So, doing separate PRs would not make sense after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants