Add 'scale factor' option to Mapnik image provider #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the optional 'scale factor' argument in the config for Mapnik's image provider. Allows a TileStache layer to be configured for retina.
Remove improper underscore
|
@jwass Aside: just started using this and it works like a charm – thanks! |
|
@brianreavis Glad to hear it! @rburhum: I can rebase this on current master, but will be difficult to add to the tests... let me know if I'm wrong about that. Anything else I can do to get this merged? |
rburhum
added a commit
that referenced
this pull request
Oct 13, 2014
Add 'scale factor' option to Mapnik image provider
|
I looked at the change. Looks good. thanks @jwass ! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the optional 'scale factor' argument in the config for Mapnik's
image provider. Allows a TileStache layer to be configured for retina.
This allows specifying the 'scale_factor' option the ImageProvider. It's used to render retina tiles.
For discussions about it, see:
https://github.com/mapnik/mapnik/wiki/Scale-factor
http://support.mapbox.com/discussions/mapbox-ios-sdk/275-retina-maps-for-completely-custom-style
https://groups.google.com/forum/#!topic/mapnik/g4MiIZu9SCk