Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use a prefix #52

Closed
bsrz opened this issue Jul 29, 2012 · 1 comment
Closed

Suggestion: Use a prefix #52

bsrz opened this issue Jul 29, 2012 · 1 comment

Comments

@bsrz
Copy link

bsrz commented Jul 29, 2012

Hi,

Sorry if this is not the proper way of giving you suggestions, I was trying to find a comment section but didn't.
This is not actually an issue however I would suggest the use of a prefix. Your classes should start with TC.
For example, ActionSheetDatePicker.h should be renamed TCActionSheetDatePicker.h.

This would ensure that there is no conflict with classes from other project. A bit like a package identifier (com.domain.package.classes) in Java.

Thanks for reading.
Ben

@skywinder
Copy link
Collaborator

Hi. Thank you!
Yes, I think it's is should be done according guidelines and as a sign of respect to the author.
I'll do this a little bit later, when I close most part of pull requests to avoid a lot of conflicts.

@ma2kubo
Copy link

ma2kubo commented May 27, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>
Subject: Re: [ActionSheetPicker] Suggestion: Use a prefix (#52)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@ma2kubo
Copy link

ma2kubo commented Jul 20, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>; ma2kubo <ma2kubo@gmail.com>
Subject: Re: [ActionSheetPicker] Suggestion: Use a prefix (#52)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants