Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public commitCurrentCrop function to expose private doneButtonTapped function #441

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

aizatomar
Copy link
Contributor

Hello again!

The exposing was simple but I tried my best to write the documentation to something similar to resetCropViewLayout function. Since this is a small PR and I do want to expose the cancelButtonTapped function to public as well. Should I create a separate PR for cancel function or can I just add that change into this PR as well?

Let me know yah. :)

@aizatomar
Copy link
Contributor Author

Forgot to add ; in previous commit :( too much Swift.

@TimOliver
Copy link
Owner

Hahaha! It's not the first time someone who was still thinking in Swift has committed some code here. 🤣

Looks good! Although like I mentioned really briefly last night, I was thinking doneButtonTapped as a name isn't really explicit enough.

If it's not too much trouble, I was thinking maybe make a new method called commitCurrentCrop and then link that to doneButtonTapped internally.

What do you think about that? :)

@aizatomar
Copy link
Contributor Author

Ah I see. So just to confirm my understanding. Wrap the private doneButtonTapped function with a public interfacing function called commitCurrentCrop. Is that it? I can do that. No problem. :)

@aizatomar
Copy link
Contributor Author

Oh how about the documentation? Let me know if I need to edit that as well yah.

@TimOliver
Copy link
Owner

Yep! You got it! That's all! :D

Uhh, nah. The documentation you already wrote is good enough as it is! Thanks for that! 😁

@aizatomar aizatomar changed the title Expose doneButtonTapped function to public Add public commitCurrentCrop function to expose private doneButtonTapped function Nov 7, 2020
@aizatomar
Copy link
Contributor Author

Ok done! :)

@TimOliver TimOliver merged commit 9d3e42a into TimOliver:master Nov 7, 2020
@TimOliver
Copy link
Owner

Fantastic! Thanks so much Aizat! :D

@aizatomar
Copy link
Contributor Author

No problem! :)

@aizatomar aizatomar deleted the done-button-tapped branch November 9, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants