SURF integration / opencv-contrib #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(surf pointer don't work correct) add orb class declaration to feature_lib.h add surf class definition to feature_lib.cpp add orb class definition to feature_lib.cpp
…OAD_DIR}/opencv-${OPENCV_VERSION}.zip. And also change the NOT EXISTS check. And also change that path in the archive_extract command
modify config flags
|
yesterday it builds with xfeatures2d |
download opencv-contrib download link edited
opencv-extra DOWNLOAD parameter(url) changed extracting opencv-extra DESTINATION parameter changed -DOPENCV_EXTRA_MODULES_PATH parameter changed
|
It builds, but xfeatures2d can't get in touch with project |
new instances of surf and orb in detection_example.cpp new print func in detection_example.cpp
zerofivefiveseven
added
ready to view
and removed
help wanted
TimPushkin
requested changes
Jul 24, 2022
There was a problem hiding this comment.
Comments on CMake style.
C++ code will be reviewed by @anastasiia-kornilova later, I guess, but in general I'd say that:
- You probably can move a lot of duplicated code from the detectors in their common abstract parent.
- In the example it would be better to accept a command line argument with the algorithm name and run only the selected one because running all three is pretty messy.
- Maybe we don't even need to print descriptors as it looks like a mess in the output -- just put descriptor size for each keypoint (in some algorithms the size may be dynamic, though, not in ours).
anastasiia-kornilova
approved these changes
Jul 24, 2022
There was a problem hiding this comment.
I absolutely agree with @TimPushkin comments, but for now it looks like they are not crucial for MVP. I suggest to move all suggestions into separate issues and after the full ready working pipeline we will beautify those things.
This was referenced Jul 24, 2022
Closed
Closed
zerofivefiveseven
force-pushed
the
cpp/dev
branch
from
aeefc6d
to
def282e
Compare
remove space between -D and OPENCV_ENABLE_NONFRE
zerofivefiveseven
force-pushed
the
cpp/dev
branch
from
def282e
to
809e7ef
Compare
remove space between -D and OPENCV_ENABLE_NONFREE
TimPushkin
approved these changes
Jul 24, 2022
now we use that func instead prev version
TimPushkin
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xfeatures2d which contains SURF appears in whitelist but don't in the library summary while build