Skip to content

Commit

Permalink
chore: Remove ServiceLoader use from the codebase (#705)
Browse files Browse the repository at this point in the history
Score Directors are now accessed directly, 
as we no longer have the need to be able to exclude some of them from the classpath.
Joiners for CS are also accessed directly, for the same reason. 
Enterprise Edition no longer uses ServiceLoader and instead uses reflection.

Because of this, core is no longer 3 Maven modules.
core, core-impl and constraint-streams modules were all folded into core,
which is now a top-level module.

All the changes are either file renames to different places and packages,
or changes strictly necessary to get rid of ServiceLoader.
There are no unrelated changes in this PR.
  • Loading branch information
triceo committed Mar 12, 2024
1 parent 05c7475 commit e473fca
Show file tree
Hide file tree
Showing 1,913 changed files with 2,553 additions and 3,173 deletions.
4 changes: 1 addition & 3 deletions benchmark/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-core-impl</artifactId>
<artifactId>timefold-solver-core</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>
Expand Down Expand Up @@ -238,11 +238,9 @@
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<ignoredUsedUndeclaredDependencies>
<dependency>ai.timefold.solver:timefold-solver-core-impl:jar</dependency>
<dependency>org.webjars:*:jar</dependency>
</ignoredUsedUndeclaredDependencies>
<ignoredUnusedDeclaredDependencies>
<dependency>ai.timefold.solver:timefold-solver-core:jar</dependency>
<dependency>org.webjars:*:jar</dependency>
</ignoredUnusedDeclaredDependencies>
</configuration>
Expand Down
26 changes: 2 additions & 24 deletions build/bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,35 +38,13 @@
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-core-impl</artifactId>
<version>${version.ai.timefold.solver}</version>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-core-impl</artifactId>
<version>${version.ai.timefold.solver}</version>
<classifier>sources</classifier>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-core-impl</artifactId>
<type>test-jar</type>
<version>${version.ai.timefold.solver}</version>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-constraint-streams</artifactId>
<version>${version.ai.timefold.solver}</version>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-constraint-streams</artifactId>
<artifactId>timefold-solver-core</artifactId>
<version>${version.ai.timefold.solver}</version>
<classifier>sources</classifier>
</dependency>
<dependency>
<groupId>ai.timefold.solver</groupId>
<artifactId>timefold-solver-constraint-streams</artifactId>
<artifactId>timefold-solver-core</artifactId>
<type>test-jar</type>
<version>${version.ai.timefold.solver}</version>
</dependency>
Expand Down
87 changes: 0 additions & 87 deletions core/constraint-streams/pom.xml

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit e473fca

Please sign in to comment.