chore: Remove ServiceLoader use from the codebase #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 11, 2024
zepfred
approved these changes
Mar 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Score Directors are now accessed directly,
as we no longer have the need to be able to exclude some of them from the classpath.
Joiners for CS are also accessed directly, for the same reason.
Enterprise Edition no longer uses ServiceLoader and instead uses reflection.
Because of this, core is no longer 3 Maven modules.
core, core-impl and constraint-streams modules were all folded into core,
which is now a top-level module.
All the changes are either file renames to different places and packages,
or changes strictly necessary to get rid of ServiceLoader.
There are no unrelated changes in this PR.