Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product with flatcontainer #570

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Product with flatcontainer #570

merged 2 commits into from
Jun 12, 2024

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Jun 11, 2024 •
edited
Loading

Implement flatcontainer support for Product.

@antiguru
Product with flatcontainer
75acdfd 
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
@antiguru
Remove ProductRef
9418950 
Signed-off-by: Moritz Hoffmann <antiguru@gmail.com>
frankmcsherry
frankmcsherry approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, or at least very localized, to me! If you'd like eyes on correctness lmk, but to the extent that it is boilerplate, it seems to be in a fine place.

@antiguru antiguru merged commit 29a2c51 into TimelyDataflow:master Jun 12, 2024
1 check passed
@antiguru antiguru deleted the product_flatcontainer branch June 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankmcsherry frankmcsherry frankmcsherry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antiguru @frankmcsherry