Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support normalization of multiple root nodes #13

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Support normalization of multiple root nodes #13

merged 1 commit into from
Dec 6, 2016

Conversation

sdepold
Copy link
Contributor

@sdepold sdepold commented Dec 6, 2016

Fix #12

sdepold
sdepold commented Dec 6, 2016
View reviewed changes
lib/index.js
return normalized;
var domNodes = convertStringToDOM(domString);

return Array.from(domNodes).map(function (domNode) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this should be translated to something else by babel since it is ES6?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced Array.from with Array.prototype.slice.call...

@TimothyRHuertas TimothyRHuertas merged commit 4388bf0 into TimothyRHuertas:master Dec 6, 2016
@TimothyRHuertas
Copy link
Owner

New version published. Thanks again for the PR.

@sdepold sdepold mentioned this pull request Dec 6, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdepold @TimothyRHuertas