Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions #1

Open
rglassett opened this issue Feb 2, 2015 · 1 comment
Open

Suggestions #1

rglassett opened this issue Feb 2, 2015 · 1 comment

Comments

@rglassett
Copy link

Nice proposal, Timur. Evernote is a good clone with a lot of nice functionality. Here are some suggestions to get you started:

  1. Notebooks already have an owner_id. Do notes really need an author_id? Shouldn't they have a notebook_id instead?
  2. Since note bodies can get quite long, I would use a text column rather than a string for those.
  3. Your JSON API isn't really a phase that adds a feature to your app. Remove this phase and build your API endpoints when they're needed (during the implementation of Notebooks or Notes)
  4. You will likely want to build separate NotesIndexItem and NoteShow views.
  5. Markdown formatting is pretty easy to implement and will make your app much cooler to use/demo. Try to add this as part of phase 4, before tagging. Do a search for WYSIWYG Markdown editors--Bootstrap Markdown is a pretty good one.

That should get you started. Looking forward to seeing the finished product!

@TimurM
Copy link
Owner

TimurM commented Feb 3, 2015

Thanks Ryan, this is really great feedback. I'll make appropriate updates.

Timur,

On Mon, Feb 2, 2015 at 2:37 PM, Ryan Glassett notifications@github.com
wrote:

Nice proposal, Timur. Evernote is a good clone with a lot of nice
functionality. Here are some suggestions to get you started:

  1. Notebooks already have an owner_id. Do notes really need an
    author_id? Shouldn't they have a notebook_id instead?
  2. Since note bodies can get quite long, I would use a text column
    rather than a string for those.
  3. Your JSON API isn't really a phase that adds a feature to your app.
    Remove this phase and build your API endpoints when they're needed (during
    the implementation of Notebooks or Notes)
  4. You will likely want to build separate NotesIndexItem and NoteShow
    views.
  5. Markdown formatting is pretty easy to implement and will make your
    app much cooler to use/demo. Try to add this as part of phase 4, before
    tagging. Do a search for WYSIWYG Markdown editors--Bootstrap Markdown is a
    pretty good one.

That should get you started. Looking forward to seeing the finished
product!


Reply to this email directly or view it on GitHub
#1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants