Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank lines removed between code block and ellipses #8

Closed
mogsdad opened this issue Oct 8, 2015 · 3 comments
Closed

Blank lines removed between code block and ellipses #8

mogsdad opened this issue Oct 8, 2015 · 3 comments
Labels
bug

Comments

@mogsdad
Copy link
Collaborator

@mogsdad mogsdad commented Oct 8, 2015

Saw this on this question. A code block is followed by prose that starts with ellipses (...). The auto-edit removed the whitespace between them, resulting in the prose being formatted as code.

});
</script>

... But I get the same result in both cases; the event fires, but only the initial center point coordinates are passed to the console.

became:

});
</script>... But I get the same result in both cases; the event fires, but only the initial center point coordinates are passed to the console.
@mogsdad mogsdad added the bug label Oct 8, 2015
@mogsdad

This comment has been minimized.

Copy link
Collaborator Author

@mogsdad mogsdad commented Oct 9, 2015

Probably due to spacesbeforesymbols which doesn't respect spaces at the start of lines:

        spacesbeforesymbols: {
            expr: /\s+([.,!?;:])(?!\w)/g,
            replacement: "$1",
            reason: "punctuation & spacing"
        },
@mogsdad mogsdad changed the title Blank lines removed between code block and elipses Blank lines removed between code block and ellipses Oct 9, 2015
mogsdad added a commit that referenced this issue Oct 9, 2015
Fixed: Blank lines removed between code block and ellipses #8
mogsdad added a commit that referenced this issue Oct 9, 2015
To avoid space collapsing in Issue #8, need to reimplement RegExp rules `blanklines` and `endblanklines` that collapse multiple blank lines.
@mogsdad

This comment has been minimized.

Copy link
Collaborator Author

@mogsdad mogsdad commented Oct 9, 2015

Merged to main.

@mogsdad mogsdad closed this Oct 9, 2015
@mogsdad

This comment has been minimized.

Copy link
Collaborator Author

@mogsdad mogsdad commented Oct 14, 2015

It's back! Fix was merged out by f04ae3b#diff-d2d08e4fa6134f3ba409bec1ddd3e970

@mogsdad mogsdad reopened this Oct 14, 2015
mogsdad added a commit that referenced this issue Oct 14, 2015
Changes for these issues had been removed by a bad merge.
@mogsdad mogsdad closed this Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.