Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace HslColor for HSLColor from painting #18

Merged
merged 14 commits into from Mar 20, 2022
Merged

Conversation

calvintam236
Copy link
Member

No description provided.

@calvintam236 calvintam236 marked this pull request as ready for review July 4, 2021 15:27
@calvintam236 calvintam236 added the enhancement New feature or request label Jul 4, 2021
@calvintam236 calvintam236 marked this pull request as draft July 6, 2021 09:49
@calvintam236 calvintam236 marked this pull request as ready for review July 10, 2021 22:27
@calvintam236 calvintam236 requested a review from WieFel July 10, 2021 22:27
@calvintam236
Copy link
Member Author

@WieFel any thoughts?

lib/src/tinycolor.dart Show resolved Hide resolved
lib/src/tinycolor.dart Show resolved Hide resolved
lib/src/tinycolor.dart Show resolved Hide resolved
lib/src/tinycolor.dart Outdated Show resolved Hide resolved
lib/src/tinycolor.dart Show resolved Hide resolved
lib/src/tinycolor.dart Show resolved Hide resolved
@WieFel
Copy link
Member

WieFel commented Jul 15, 2021

@calvintam236 sorry, I forgot to press submit review button 😬

@calvintam236
Copy link
Member Author

@WieFel @dsyrstad do you have a list of expected result from test? Upon checking, the test is basically empty, not checking for output. I can write the test if someone can gave me the parameter input and expected output.

@WieFel
Copy link
Member

WieFel commented Aug 1, 2021

I would say

  1. Copy every "old" version of the functions I commented on.
  2. Put them in the test file and name them e.g. lightenOld(), etc.
  3. For every function, loop from through the range of min to max allowed value. E.g. in the case of lighten from 0 to 100, for example with step of 10.
  4. Compare output of "old" with "new" function and assert they are equal.

@calvintam236
Copy link
Member Author

I would say

  1. Copy every "old" version of the functions I commented on.
  2. Put them in the test file and name them e.g. lightenOld(), etc.
  3. For every function, loop from through the range of min to max allowed value. E.g. in the case of lighten from 0 to 100, for example with step of 10.
  4. Compare output of "old" with "new" function and assert they are equal.

I am referring to writing tests for CI. It does not work for testing in the future.

@WieFel
Copy link
Member

WieFel commented Sep 19, 2021

@calvintam236 sorry for not answering. I am very busy with work.
Just try to come up with some ideas yourself and we can discuss it ;)

@calvintam236
Copy link
Member Author

Blocked by #35

@calvintam236 calvintam236 added this to the v2.1.0 milestone Mar 8, 2022
@calvintam236
Copy link
Member Author

@WieFel I just added test for HSL. They are passed so it should be okay.

@calvintam236
Copy link
Member Author

Note that the ci/format test can be ignored at this moment as the tests will be updated again in #41.

@calvintam236 calvintam236 merged commit 2415dbd into master Mar 20, 2022
@calvintam236 calvintam236 deleted the feature/hslcolor branch March 20, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants