New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite tests #35
Rewrite tests #35
Conversation
@WieFel Any good idea how to test all the setters? |
@calvintam236 probably the only way is to set some value and use the getters in the same way as you did in the getters tests |
@WieFel The problem is what are the expected value of each setter since they all return |
Not sure how to best test this... Maybe check something like |
@WieFel I added the remaining tests by testing every methods independently. Should this sufficient? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.