Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new development strategy. #52

Open
guillaumearm opened this issue Oct 20, 2016 · 5 comments
Open

new development strategy. #52

guillaumearm opened this issue Oct 20, 2016 · 5 comments

Comments

@guillaumearm
Copy link
Collaborator

guillaumearm commented Oct 20, 2016

due to #37, we need to be careful about staging.

react-redux-polyglot use redux-polyglot as main dependency, so i think we need to work on a devbranch and follow this 3 principles :

  • this branch must be as clean as master, so npm run prepublish must be ok.
  • all master merges should be tagged by a new version. (on the master branch only)
  • all change must be validated by react-redux-polyglot unit testing before merge on master ( maybe find for an automation )

todo before close this issue :

  • create a dev branch [DONE]
  • explain this principles in redux-polyglot CONTRIBUTING.md [DONE]
  • pre-release react-redux-polyglot 0.0.1
  • write documentation for this when it's done.

note: please see react-redux-polyglot/issues/3

@guillaumearm
Copy link
Collaborator Author

I think this issue must be a priority. @JalilArfaoui ? @jvincent42 ?

@guillaumearm
Copy link
Collaborator Author

dev branch created.

guillaumearm pushed a commit that referenced this issue Nov 2, 2016
Because #37 and #52,
need to explain the 3 principles of issue #52.
@guillaumearm
Copy link
Collaborator Author

PR here in #55

@JalilArfaoui
Copy link
Contributor

As we discussed @guillaumearm we should merge both redux-polyglot and react-redux-polyglot NPM modules in the same repository to ensure full synchronicity and simpler tests.

@JalilArfaoui
Copy link
Contributor

Can we close this one ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants