Fix implicit function declarations with clang (#382)

Use global declaration of _GNU_SOURCE via Makefile That fixes some warnings about implicit function declarations for different compilers
Tlf · Nov 3, 2023 · 3e60a4e · 3e60a4e
1 parent 563f35b
commit 3e60a4e
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 38 deletions.
diff --git a/src/Makefile.am b/src/Makefile.am
@@ -1,5 +1,5 @@
 AM_CPPFLAGS = @GLIB_CFLAGS@ -DPACKAGE_DATA_DIR=\"$(pkgdatadir)\" @PYTHON_INCLUDE@
-AM_CFLAGS = @AM_CFLAGS@ @PTHREAD_CFLAGS@ @HAMLIB_CFLAGS@ @CURSES_CFLAGS@
+AM_CFLAGS = @AM_CFLAGS@ @PTHREAD_CFLAGS@ @HAMLIB_CFLAGS@ @CURSES_CFLAGS@ -D_GNU_SOURCE
 
 bin_PROGRAMS = tlf
 

diff --git a/src/addcall.c b/src/addcall.c
@@ -23,13 +23,6 @@
  *      add call/band to dupe list
  *
  *--------------------------------------------------------------*/
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
-
-#ifndef _XOPEN_SOURCE
-#define _XOPEN_SOURCE
-#endif
 
 #include <stdlib.h>
 #include <string.h>

diff --git a/src/cabrillo_utils.c b/src/cabrillo_utils.c
@@ -24,10 +24,6 @@
  *--------------------------------------------------------------*/
 
 
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
-
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>

diff --git a/src/get_time.c b/src/get_time.c
@@ -25,9 +25,6 @@
 *  All functions operate on UTC dates/times.
 ---------------------------------------------------------------------------*/
 
-#ifndef _XOPEN_SOURCE
-#define _XOPEN_SOURCE
-#endif
 #include <time.h>
 #include <string.h>
 

diff --git a/src/log_utils.c b/src/log_utils.c
@@ -21,10 +21,6 @@
 *
 ---------------------------------------------------------------------------*/
 
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
-
 #include <ctype.h>
 #include <glib.h>
 #include <stdlib.h>

diff --git a/src/readcabrillo.c b/src/readcabrillo.c
@@ -17,9 +17,6 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#ifndef _XOPEN_SOURCE
-#define _XOPEN_SOURCE
-#endif
 #include <stdio.h>
 #include <string.h>
 #include <unistd.h>

diff --git a/src/readcalls.c b/src/readcalls.c
@@ -23,9 +23,6 @@
  *
  *--------------------------------------------------------------*/
 
-#ifndef _XOPEN_SOURCE
-#define _XOPEN_SOURCE
-#endif
 
 #include <stdio.h>
 #include <stdlib.h>

diff --git a/src/rules.c b/src/rules.c
@@ -19,10 +19,6 @@
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
 */
 
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE	// For asprintf()
-#endif
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>

diff --git a/src/searchlog.c b/src/searchlog.c
@@ -23,11 +23,6 @@
  *
  *--------------------------------------------------------------*/
 
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
-
-
 #include <stdbool.h>
 #include <stdlib.h>
 #include <string.h>

diff --git a/src/writecabrillo.c b/src/writecabrillo.c
@@ -23,10 +23,6 @@
  *--------------------------------------------------------------*/
 
 
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE
-#endif
-
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>