Provide a fallback for M_PI and M_PI_2 #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we just define one of these? For example drop |
|
Makes sense. I would also move the definition of RADIANS there. a) prepare a tlf_math.h (which includes math.h and defines M_PI_2 if needed) and include it everywhere instead of math.h. b) define it in sunup.h as that is already needed by muf.c (but has to be added to sunup.c yet). |
|
Fine with me, thanks. |
|
Thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As C standards does not define M_PI or M_PI_2 provide a fallback. Some LIBC implementations (e.g. MUSL) miss these definitions.