Fix 2-character prefix search #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As expected test fails with "G8ERJ" != "G" |
|
Now fixed. |
|
Nice problem. Maybe add to comment that having a unique prefix is only enough if call has not to be exact. Otherwise whole call should match. Otherwise looks good and should go in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In September 2018 cty.dat (https://www.country-files.com/cty-2810-04-september-2018/) added G8ERJ to US
This causes all G8 calls considered as US calls. There was a missing logic to handle exact matches correctly.
First added a test for it.