Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max recursion error in WordPress 4.7 #44

Closed
Shelob9 opened this issue Dec 6, 2016 · 11 comments
Closed

Max recursion error in WordPress 4.7 #44

Shelob9 opened this issue Dec 6, 2016 · 11 comments

Comments

@Shelob9
Copy link

Shelob9 commented Dec 6, 2016

I am getting fatal error maximum recursion after updating to WP 4.7. Not able to debug right now, so disabled to fix. Here is my stack trace:

Stack trace: https://pastebin.com/XiGu10jC

@brunoguimaraes
Copy link

WP 4.7, Multisite install, authentication and WP-API works fine, but wp-admin throws ERR_EMPTY_RESPONSE error on Chrome.

@Shelob9
Copy link
Author

Shelob9 commented Dec 7, 2016

@brunoguimaraes Do you have WP_DEBUG and WP_DEBUG_LOG on?

@faugro
Copy link

faugro commented Dec 7, 2016

@Shelob9
After whole day get this error, my temporary fix by editing
jwt-authentication-for-wp-rest-api\public\class-jwt-auth-public.php line 227
__('Authorization header not found.', 'wp-api-jwt-auth'),
change to
'Authorization header not found.',

Hope this help

@brunoguimaraes
Copy link

@Shelob9 Yes, both options activated.

@Tmeister
Copy link
Owner

Tmeister commented Dec 7, 2016

I'm digging on this, looks like the determine_current_user hook is guilty of this, this hook should only run on the REST API requests.

@Shelob9
Copy link
Author

Shelob9 commented Dec 7, 2016

@Tmeister Removing that filter while inside of the callback should (sorry, reading not testing) fix this.

Tmeister added a commit that referenced this issue Dec 7, 2016
@Tmeister
Copy link
Owner

Tmeister commented Dec 7, 2016

I just push a new version (1.2.3) in WP.org, and here with the fix, all my local tests work good, and the recursion error is fixed!

Please verify on your end and let me know if you see anything odd.

Will left this open a couple of days to see if something came off.

@brunoguimaraes
Copy link

@Tmeister This update fixes my issue, thank you!

@Shelob9
Copy link
Author

Shelob9 commented Dec 8, 2016

Working for me too now. Thanks for the fix!

@Tmeister
Copy link
Owner

Tmeister commented Dec 9, 2016

I think we can close this.

@Tmeister Tmeister closed this as completed Dec 9, 2016
@Shelob9
Copy link
Author

Shelob9 commented Dec 9, 2016

Strong agreement. Thanks for the great plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants