Fix: configure duckdb with connector_config settings. #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crericha
force-pushed
the
duckdb-connector-config
branch
from
0f7a851
to
b9f83db
Compare
|
Thx, @crericha, for the quick fix. A checkout does fix the parsing issue from what I can tell. I'm not yet able to read from s3 due to a new error, but I'll file something once I narrow down the problem. |
izeigerman
reviewed
Mar 11, 2024
| @@ -150,6 +146,12 @@ def init(cursor: duckdb.DuckDBPyConnection) -> None: | |||
| except Exception as e: | |||
| raise ConfigError(f"Failed to load extension {extension}: {e}") | |||
|
|
|||
| for field, setting in self.connector_config.items(): | |||
| try: | |||
| cursor.execute(f"SET {field} = '{setting}'") | |||
There was a problem hiding this comment.
Is value always a string literal?
There was a problem hiding this comment.
Here is a list of settings. I cannot confirm that all of these settings can be changed using SET {field}, but there are definitely other types included in this list:
There was a problem hiding this comment.
This mimics dbt's behavior.
izeigerman
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duckdb.connectdoes not properly parse config dicts that are passed into it, so instead set each config setting directly in duckdb when we init the cursor.