Refactor!: error when trying to construct source queries from empty DFs #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
approved these changes
Jun 19, 2024
tobymao
reviewed
Jun 19, 2024
georgesittas
commented
Jun 20, 2024
| "is commonly related to Python models that produce no data.\nFor such " | ||
| "models, consider yielding from an empty generator if the resulting set " | ||
| "\nis empty, i.e. use `yield from ()`" | ||
| ) in capsys.readouterr().out |
There was a problem hiding this comment.
I tested this using capsys because if I do pytest.raises(SQLMeshError, match=...) it captures the Plan application failed. exception which doesn't include the exception of interest in its context.
georgesittas
force-pushed
the
jo/handle_empty_df_in_source_queries
branch
from
3ff7ba1
to
3f6d15f
Compare
izeigerman
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2769