Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid passing encoding creation option to format drivers that don't support it #504

Closed
sgillies opened this issue Nov 16, 2017 · 5 comments
Closed

Avoid passing encoding creation option to format drivers that don't support it #504

sgillies opened this issue Nov 16, 2017 · 5 comments
Labels
bug
Milestone
1.9

Comments

@sgillies
Copy link
Member

sgillies commented Nov 16, 2017 •
edited
Loading

See #468 (comment): the GeoJSON driver warns that ENCODING isn't supported.

@mattayes the warning is harmless but we can avoid it.
@sgillies sgillies added this to the 1.8.0 milestone Nov 16, 2017
@sgillies sgillies added the bug label Nov 16, 2017
@snorfalorpagus
Copy link
Member

I can't see any way to ask GDAL which creation options are supported by a driver/dataset/layer. Do we need to build our own list for the drivers we support?

@sgillies
Copy link
Member Author

According to http://www.gdal.org/gdal_8h.html#aec318ffe797555656fe678558c576b23 GDALValidateCreationOptions will validate options, and there's a hint about a GDAL_DMD_CREATIONOPTIONLIST driver metadata item.

Still, I think the immediate thing for me to do is to eliminate the encoding option in the GeoJSON case.

@snorfalorpagus
Copy link
Member 

Warning 6: driver MapInfo File does not support creation option ENCODING

Looks like MapInfo is the same.

@sgillies sgillies modified the milestones: 1.8.0, post-1.8 Oct 1, 2018
@kurt-rhee
Copy link

KML driver as well

not recognized as a supported file format. driver KML does not support creation option ENCODING

@rbuffat rbuffat mentioned this issue Jun 5, 2020
Closed
@sgillies sgillies modified the milestones: post-1.8, 1.9 Oct 11, 2020
sgillies added a commit that referenced this issue Jan 22, 2023
@sgillies
Invalid creation options are filtered and ignored
7323442 
Resolves #504 in a more general way than previously.
@sgillies sgillies mentioned this issue Jan 22, 2023
Merged
sgillies added a commit that referenced this issue Jan 22, 2023
@sgillies
Invalid creation options are filtered and ignored (#1180)
2eddb65 
* Invalid creation options are filtered and ignored

Resolves #504 in a more general way than previously.

* Update change log
@sgillies
Copy link
Member Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
3 participants
@sgillies @snorfalorpagus @kurt-rhee