Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy GDAL API C files in clean target. #361

Closed
wants to merge 1 commit into from

Conversation

sebastic
Copy link
Contributor

da85e95 broke the clean target again, because it changes the sources when it shouldn't. This was fixed earlier via #322.

@sgillies
Copy link
Member

It's a little more complicated than this. The source distribution contains an ogrext1.c and an ogrext2.c file now and we use the one suited to the builder's GDAL API version. I'm going to make a new PR that does this without copying files.

Can you remind me how the clean target is used within a Debian build @sebastic?

@sebastic
Copy link
Contributor Author

The separate targets are called in the various stages of the build:

python setup.py clean
python setup.py config
python setup.py build
python setup.py install --root <DESTDIR>

The clean target is first executed outside the build chroot, and then again inside the chroot as part of the sequence above (which is executed for every Python version).

@sgillies
Copy link
Member

Replaced by #362.

@sgillies sgillies closed this Jun 15, 2016
@sebastic sebastic deleted the clean-setup branch June 15, 2016 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants