Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't copy files for clean target #362

Merged
merged 2 commits into from Jun 15, 2016
Merged

Don't copy files for clean target #362

merged 2 commits into from Jun 15, 2016

Conversation

sgillies
Copy link
Member

Debian builds were broken by this regression.

@sgillies sgillies added the bug label Jun 15, 2016
@sgillies sgillies merged commit 4d11411 into master Jun 15, 2016
@sgillies sgillies deleted the no-copy branch June 15, 2016 14:52
@sebastic
Copy link
Contributor

Because ext_modules is defined in the the if/elif blocks, if none of the conditions match the variable remains undefined causing an error:

$ python2.7 setup.py clean 
Traceback (most recent call last):
  File "setup.py", line 248, in <module>
    ext_modules=ext_modules,
NameError: name 'ext_modules' is not defined

This was explicitly handled by my PR, see: setup.py line 180

sebastic added a commit to sebastic/Fiona that referenced this pull request Jun 15, 2016
sgillies added a commit that referenced this pull request Jun 15, 2016
Fix undefined ext_modules introduced via #362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants