Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility for in-app URL's #391

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Utility for in-app URL's #391

merged 3 commits into from
Feb 28, 2022

Conversation

Tais993
Copy link
Member

@Tais993 Tais993 commented Feb 20, 2022

This implements a class which eases the developer to generate URL's to items within the Discord app.

A feature should NOT rely on this class, Discord can change something anytime, and iOS + Android aren't supported. They're there to enhance the functionality without making it worse.

If anyone has ideas for screens I could look at to find or there's URL(s) for, you can always send a message and I'll take a look or I can find anything.

Closes #387

@Tais993 Tais993 self-assigned this Feb 20, 2022
@Tais993 Tais993 requested review from a team as code owners February 20, 2022 14:30
@Tais993 Tais993 added documentation Improvements or additions to documentation enhancement New feature or request priority: low labels Feb 20, 2022
@Tais993 Tais993 added this to the Improvement phase 1 milestone Feb 20, 2022
@Tais993 Tais993 added this to In progress in Improvement phase 1 via automation Feb 20, 2022
@Tais993 Tais993 force-pushed the feature/discord-client-actions branch from ee22352 to de320d3 Compare February 20, 2022 14:32
@Tais993 Tais993 changed the title Added DiscordClientAction Add class which contains all actions Discord allows within the client Feb 20, 2022
@Tais993 Tais993 changed the title Add class which contains all actions Discord allows within the client Utility for in-app URL's Feb 20, 2022
@Tais993 Tais993 mentioned this pull request Feb 20, 2022
2 tasks
@Tais993 Tais993 force-pushed the feature/discord-client-actions branch from de320d3 to 7870309 Compare February 20, 2022 15:28
This allows the user to generate URL's which link to items in the Discord app (a channel, settings etc)
@Tais993 Tais993 force-pushed the feature/discord-client-actions branch from 7870309 to bb51b84 Compare February 20, 2022 15:31
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Can you give a few examples of how to use this class? Maybe also put them into the Javadoc, thanks.

@Tais993 Tais993 force-pushed the feature/discord-client-actions branch from 1fad968 to 73f262f Compare February 24, 2022 22:35
@Tais993 Tais993 force-pushed the feature/discord-client-actions branch from 73f262f to cd888e1 Compare February 24, 2022 22:36
@Tais993
Copy link
Member Author

Tais993 commented Feb 24, 2022

Added 2 short examples in the Javadoc, hopefully they explain enough?
@Zabuzard

Zabuzard
Zabuzard previously approved these changes Feb 25, 2022
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fix the linter stuff though 👍 )

@Tais993 Tais993 force-pushed the feature/discord-client-actions branch from 9df08e9 to 6328621 Compare February 25, 2022 10:14
@Tais993 Tais993 force-pushed the feature/discord-client-actions branch from 6328621 to fb158c3 Compare February 25, 2022 10:16
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Tais993 Tais993 merged commit 16d66b5 into develop Feb 28, 2022
Improvement phase 1 automation moved this from In progress to Done Feb 28, 2022
@Tais993 Tais993 deleted the feature/discord-client-actions branch February 28, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request priority: low
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Utility for in-app URL's
3 participants