-
-
Notifications
You must be signed in to change notification settings - Fork 92
Fix link for report's 'go to message' button #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A bit of a background on this PR. Link buttons with Not sure if those ever worked. This PR looks fine, but it does intentionally sidestep our own utility for handling URIs, which should be noted. For example, all link buttons generated with it have the same issue. Which raises the question, what's the appropriate way to deal with this? Discord URI scheme doesn't seem to be documented at all? How can other systems even support it? How can we even rely on it? How can I learn about it? Am I missing something? 😩
It works on my android, so I guess that's not true anymore.
So I guess we should offer regular links whenever possible. For example, regular message link in addition to report's 'go to message', and mention (so you can right-click) in addition to modmail's 'author profile'. |
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/commands/moderation/ReportCommand.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
The current weird link doesn't seem to work on linux systems.
This is a simple link and used more frequently and works on linux systems too