feat: hardcoded analytics limited to 3 month! #274
Conversation
WalkthroughThe changes involve a modification to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
dags/analyzer_helper/common/analyzer.py (1)
Line range hint
10-40: Suggest refactoring to improve maintainability.The
analyzemethod handles multiple responsibilities, which could be separated into smaller, more focused methods to improve readability and maintainability. Consider refactoring the method by separating the period adjustment, analytics computation, and result publishing into separate methods.Here's a proposed refactor to enhance the method's structure:
class Analyzer: def adjust_period(self, period): if (datetime.now() - period).days >= 90: return datetime.now().replace(hour=0, minute=0, second=0, microsecond=0) return period def compute_analytics(self, platform_id, resources, period, action, window, config, recompute): analyzer = TCAnalyzer( platform_id=platform_id, resources=resources, period=period, action=action, window=window, analyzer_config=config, ) if recompute: logging.info(f"PLATFORMID: {platform_id} recomputing analyzer!") asyncio.run(analyzer.recompute()) else: logging.info(f"PLATFORMID: {platform_id} append analytics to previous analytics results!") asyncio.run(analyzer.run_once()) def analyze( self, platform_id: str, resources: list[str], period: datetime, action: dict[str, int], window: dict[str, int], recompute: bool, config: PlatformConfigBase = DiscordAnalyzerConfig(), ) -> None: period = self.adjust_period(period) self.compute_analytics(platform_id, resources, period, action, window, config, recompute) publish_on_success(platform_id, recompute)
| # limiting to 90 days | ||
| if (datetime.now() - period).days > 90: | ||
| period = (datetime.now() - timedelta(days=0)).replace( | ||
| hour=0, minute=0, second=0, microsecond=0 | ||
| ) |
There was a problem hiding this comment.
Review the new conditional logic for period limitation.
The new logic introduced to limit the analysis period to 90 days is crucial for ensuring data relevance. However, there are a few points to consider:
- The calculation
(datetime.now() - period).days > 90effectively checks if the period is older than 90 days from today, which aligns with the PR objectives. - The reset of
periodto midnight of the current day usingdatetime.now().replace(hour=0, minute=0, second=0, microsecond=0)is a clean way to handle this limitation.
However, this approach may introduce a subtle bug:
- If the
periodis exactly 90 days old, it will not be reset, which might not be the intended behavior. Consider adjusting the condition to>= 90to include the 90th day as well.
Consider this adjustment for inclusivity of the 90th day:
-if (datetime.now() - period).days > 90:
+if (datetime.now() - period).days >= 90:Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # limiting to 90 days | |
| if (datetime.now() - period).days > 90: | |
| period = (datetime.now() - timedelta(days=0)).replace( | |
| hour=0, minute=0, second=0, microsecond=0 | |
| ) | |
| # limiting to 90 days | |
| if (datetime.now() - period).days >= 90: | |
| period = (datetime.now() - timedelta(days=0)).replace( | |
| hour=0, minute=0, second=0, microsecond=0 | |
| ) |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- dags/analyzer_helper/common/analyzer.py (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- dags/analyzer_helper/common/analyzer.py
Summary by CodeRabbit