Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build nTox by default with CMake #292

Closed
zetok opened this issue Nov 27, 2016 · 2 comments
Closed

Don't build nTox by default with CMake #292

zetok opened this issue Nov 27, 2016 · 2 comments
Labels
P3 Low priority
Milestone
v0.1.0

Comments

@zetok
Copy link

zetok commented Nov 27, 2016

There should be an opt-in option instead, just like with autotools.
@zetok zetok mentioned this issue Nov 27, 2016
Closed
@robinlinden
Copy link
Member

robinlinden commented Nov 27, 2016 •
edited

There is a cmake flag for it, actually.
https://github.com/TokTok/c-toxcore/blob/master/CMakeLists.txt#L483

Though, I do agree that it should default to off.

@zetok
Copy link
Author

zetok commented Nov 27, 2016

Good, then someone with knowledge how to enable CMake options should make a PR to

  • switch it to OFF by default
  • test scripts should enable it
  • add docs in INSTALL.md on how to enable it using CMake

@iphydf iphydf modified the milestone: v0.0.6 Dec 2, 2016
iphydf added a commit to iphydf/c-toxcore that referenced this issue Dec 5, 2016
@iphydf
Don't build nTox by default.
d8ae726 
Build it on Travis. It won't be built on the windows builds regardless
of having it enabled globally.

Fixes TokTok#292.
@iphydf iphydf mentioned this issue Dec 5, 2016
Merged
@iphydf iphydf modified the milestones: v0.0.6, v0.1.0 Dec 10, 2016
@iphydf iphydf added the P3 Low priority label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Low priority
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
3 participants
@zetok @robinlinden @iphydf