Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INSTALL.md #291

Closed
wants to merge 1 commit into from
Closed

Update INSTALL.md #291

wants to merge 1 commit into from

Conversation

cebe
Copy link
Member

@cebe cebe commented Nov 27, 2016

Added missing package libncurses5-dev to Debian/Ubuntu instructions. Otherwise cmake will fail complaining about the missing library:

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
NCURSES_LIBRARIES
    linked by target "nTox" in directory /home/cebe/dev/tox/c-toxcore

-- Configuring incomplete, errors occurred!

This change is Reviewable

Added missing package `libncurses5-dev` to Debian/Ubuntu instructions. Otherwise cmake will fail complaining about the missing library:

```
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
NCURSES_LIBRARIES
    linked by target "nTox" in directory /home/cebe/dev/tox/c-toxcore

-- Configuring incomplete, errors occurred!
```
@robinlinden
Copy link
Member

I also ran into this problem compiling c-toxcore. :lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@zetok
Copy link

zetok commented Nov 27, 2016

Err, this is a work-around at best for the actual issue: #292

IMO shouldn't be merged, and issue should be fixed instead.

@cebe
Copy link
Member Author

cebe commented Nov 27, 2016

agree, did not know what it was used for. closing this in favor of #292

@cebe cebe closed this Nov 27, 2016
@cebe cebe deleted the patch-1 branch November 27, 2016 15:58
@iphydf iphydf added this to the v0.0.6 milestone Dec 2, 2016
@iphydf iphydf modified the milestones: v0.0.6, v0.1.0 Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants