Use enums for group packet types.#1007
Merged
Merged
Conversation
iphydf
force-pushed
the
pgc-packet-type-enum
branch
from
896dcbe to
783c6dd
Compare
|
This <img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/>
|
iphydf
force-pushed
the
pgc-packet-type-enum
branch
2 times, most recently
from
2388096 to
1d1b236
Compare
robinlinden
approved these changes
Jul 18, 2018
robinlinden
left a comment
robinlinden
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 LGTMs obtained, and 1 stale
Also moved some macros up to the beginning of `group.c`. This change brings us closer to the PGC PR.
iphydf
force-pushed
the
pgc-packet-type-enum
branch
from
1d1b236 to
7f6c681
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moved some macros up to the beginning of
group.c. This changebrings us closer to the PGC PR.
This change is