Fix groupav.c style and avoid casts in toxav_old.c.#1082
Merged
iphydf merged 1 commit intoTokTok:masterfrom Aug 13, 2018
Merged
Fix groupav.c style and avoid casts in toxav_old.c.#1082iphydf merged 1 commit intoTokTok:masterfrom
iphydf merged 1 commit intoTokTok:masterfrom
Conversation
iphydf
force-pushed
the
groupav-style
branch
3 times, most recently
from
e1fd22b to
5d2fa96
Compare
hugbubby
reviewed
Aug 13, 2018
toxav/groupav.c
Outdated
Member
There was a problem hiding this comment.
What are you some kinda babby who can't handle assigning variables within if statements
Member
Author
There was a problem hiding this comment.
If this question is serious, let me know and I'll be happy to talk about it.
hugbubby
reviewed
Aug 13, 2018
toxav/groupav.c
Outdated
hugbubby
reviewed
Aug 13, 2018
toxav/groupav.c
Outdated
Member
There was a problem hiding this comment.
I actually prefer this for its intuition
hugbubby
approved these changes
Aug 13, 2018
Member
hugbubby
left a comment
hugbubby
left a comment
There was a problem hiding this comment.
The old stuff was actually so bad it blurs the line between style checks and bugfixing
hugbubby
reviewed
Aug 13, 2018
Member
hugbubby
left a comment
hugbubby
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 approvals obtained
hugbubby
approved these changes
Aug 13, 2018
Member
hugbubby
left a comment
hugbubby
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:
zoff99
approved these changes
Aug 13, 2018
* No anonymous structs. * No assignment expressions. * Only one declarator per struct member declaration. * Named callback types only, no inline types. * No `;` empty statements. * `++i` instead of `i++`. Avoiding a cast in toxav_old.c avoids some potential (and real) bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
;empty statements.++iinstead ofi++.Avoiding a cast in toxav_old.c avoids some potential (and real) bugs.
This change is