Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use (void) for empty parameter lists in C. #1150

Merged
merged 1 commit into from Sep 8, 2018
Merged

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 8, 2018

Because () means "some unknown number of parameters".


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 8, 2018
@iphydf iphydf requested a review from Diadlo September 8, 2018 07:29
Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @Diadlo)

Because `()` means "some unknown number of parameters".
@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #1150 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1150     +/-   ##
========================================
- Coverage    82.8%   82.7%   -0.2%     
========================================
  Files          82      82             
  Lines       14667   14594     -73     
========================================
- Hits        12158   12074     -84     
- Misses       2509    2520     +11
Impacted Files Coverage Δ
auto_tests/dht_test.c 48% <100%> (ø) ⬆️
auto_tests/onion_test.c 86.5% <100%> (ø) ⬆️
auto_tests/TCP_test.c 100% <100%> (ø) ⬆️
toxav/toxav.c 68.1% <0%> (-1%) ⬇️
toxcore/friend_connection.c 93.6% <0%> (-0.9%) ⬇️
toxcore/Messenger.c 85.8% <0%> (-0.8%) ⬇️
toxcore/net_crypto.c 93% <0%> (-0.5%) ⬇️
toxcore/group.c 76% <0%> (-0.3%) ⬇️
toxcore/onion_client.c 95.2% <0%> (-0.2%) ⬇️
toxav/msi.c 65.6% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08cc418...d9541d5. Read the comment docs.

Copy link
Member

@nurupo nurupo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @Diadlo)

@iphydf iphydf removed the request for review from Diadlo September 8, 2018 11:11
@iphydf iphydf merged commit d9541d5 into TokTok:master Sep 8, 2018
@iphydf iphydf deleted the void-param branch September 8, 2018 11:12
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants