Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new @pthread library from toktok-stack for Windows compat. #1197

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

iphydf
Copy link
Member

@iphydf iphydf commented Sep 22, 2018

See TokTok/toktok-stack#38.


This change is Reviewable

@iphydf iphydf added this to the v0.2.x milestone Sep 22, 2018
@iphydf iphydf changed the title Use new @pthread library from Bazel for Windows compat. Use new @pthread library from toktok-stack for Windows compat. Sep 23, 2018
Copy link
Member

@robinlinden robinlinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained

@codecov
Copy link

codecov bot commented Sep 26, 2018

Codecov Report

Merging #1197 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1197     +/-   ##
========================================
- Coverage      83%   82.8%   -0.3%     
========================================
  Files          82      82             
  Lines       14645   14646      +1     
========================================
- Hits        12167   12129     -38     
- Misses       2478    2517     +39
Impacted Files Coverage Δ
auto_tests/network_test.c 90.3% <0%> (-7.3%) ⬇️
toxcore/TCP_client.c 64.3% <0%> (-2.8%) ⬇️
toxcore/TCP_server.c 75% <0%> (-2.8%) ⬇️
toxcore/net_crypto.c 92.9% <0%> (-1.5%) ⬇️
toxcore/LAN_discovery.c 84.9% <0%> (-1%) ⬇️
toxav/msi.c 63.9% <0%> (-0.3%) ⬇️
toxcore/Messenger.c 86.5% <0%> (-0.2%) ⬇️
toxcore/onion_client.c 95.3% <0%> (ø) ⬆️
toxcore/friend_connection.c 94.8% <0%> (+0.2%) ⬆️
toxav/toxav.c 67.3% <0%> (+0.3%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f266f9...a94d032. Read the comment docs.

@iphydf iphydf merged commit a94d032 into TokTok:master Sep 26, 2018
@iphydf iphydf deleted the pthread-bazel branch September 26, 2018 00:17
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.8 Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants