Add cmake option for building additional tests#1278
Conversation
sudden6
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 approvals obtained
|
Did you test if it fixes the build failure with the It would be nice to print a message for every option we are overriding, e.g. if |
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
========================================
- Coverage 83.7% 83.3% -0.5%
========================================
Files 82 82
Lines 14827 14827
========================================
- Hits 12416 12351 -65
- Misses 2411 2476 +65
Continue to review full report at Codecov.
|
|
* Sunday, 2018-12-09 at 16:08 -0800 - nurupo <notifications@github.com>:
Did you test if it fixes the build failure with the `STRICT_ABI` flag?
Yes, it works fine for me.
It would be nice to print a message for every option we are overriding,
Good idea. I've implemented that now (though if someone knows cmake and
can avoid the code duplication involved, that would be nice).
|
|
@zugs You need to sign your commits with a GPG key before they can be merged. I know it's possible for me to sign them because iphydf did that for me once, but I don't know how. |
Closes #1262
This change is