Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake option for building additional tests #1278

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

zugz
Copy link

@zugz zugz commented Dec 8, 2018

Closes #1262


This change is Reviewable

Copy link

@sudden6 sudden6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 1 approvals obtained

@nurupo
Copy link
Member

nurupo commented Dec 10, 2018

Did you test if it fixes the build failure with the STRICT_ABI flag?

It would be nice to print a message for every option we are overriding, e.g. if STRICT_ABI=ON and AUTOTEST=ON do message(WARNING "AUTOTEST option is not compatible with STRICT_ABI option. Disabling AUTOTEST"). Someone might get confused as to why autotests didn't build when they asked for them to be built.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #1278 into master will decrease coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1278     +/-   ##
========================================
- Coverage    83.7%   83.3%   -0.5%     
========================================
  Files          82      82             
  Lines       14827   14827             
========================================
- Hits        12416   12351     -65     
- Misses       2411    2476     +65
Impacted Files Coverage Δ
toxcore/TCP_client.c 64.6% <0%> (-2.9%) ⬇️
toxav/msi.c 63.9% <0%> (-2.8%) ⬇️
toxcore/TCP_server.c 80.3% <0%> (-2.6%) ⬇️
toxav/toxav.c 67.7% <0%> (-1.5%) ⬇️
toxcore/friend_connection.c 94.9% <0%> (-1.2%) ⬇️
toxcore/DHT.c 76.8% <0%> (-1%) ⬇️
toxcore/network.c 82.1% <0%> (-0.5%) ⬇️
toxcore/net_crypto.c 95.1% <0%> (-0.3%) ⬇️
toxcore/Messenger.c 86.7% <0%> (-0.3%) ⬇️
toxcore/onion_client.c 96% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9770880...0f8f82a. Read the comment docs.

@zugz
Copy link
Author

zugz commented Dec 10, 2018 via email

@hugbubby
Copy link
Member

@zugs You need to sign your commits with a GPG key before they can be merged. I know it's possible for me to sign them because iphydf did that for me once, but I don't know how.

@iphydf iphydf merged commit 0f8f82a into TokTok:master Dec 12, 2018
@iphydf iphydf added this to the v0.2.x milestone Jan 3, 2019
@robinlinden robinlinden modified the milestones: v0.2.x, v0.2.9 Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants