Version Patch v0.0.2 #202
Version Patch v0.0.2 #202
Conversation
|
This incorrectly passes tests. The tests are broken, I'll fix them. |
|
blocked by #204 ping me on merge so I can rebase. |
|
@GrayHatter ping: #204 is merged, please rebase. |
|
@iphydf done |
|
@GrayHatter at the very least you have missed https://github.com/TokTok/c-toxcore/blob/master/CMakeLists.txt#L9. Please check the coomit that did 0.0.1 version tick and see if anything esle is missing. |
|
I don't like that version number is spread all over the project. Is it possible to keep it in single place? People will change version every release, and people will forget to change it somewhere in those files. Also even having it in multiple places, you cannot simply search for "0.0.1" string as it is broken into separate major, minor, patch components. |
|
@dvor there is already a script for updating versions in all the places, I'm not sure why @GrayHatter is not using it. All you need to do is bump the version in CMakeLists.txt and it will run https://github.com/TokTok/c-toxcore/blob/master/other/version-sync https://github.com/TokTok/c-toxcore/blob/master/CMakeLists.txt#L458 which should update the version number everywhere. |
|
|
||
| update 'CMakeLists.txt' 's/^\(set(PROJECT_VERSION_MAJOR \"\).*")/\1'$MAJOR'")/' | ||
| update 'CMakeLists.txt' 's/^\(set(PROJECT_VERSION_MINOR \"\).*")/\1'$MINOR'")/' | ||
| update 'CMakeLists.txt' 's/^\(set(PROJECT_VERSION_PATCH \"\).*")/\1'$PATCH'")/' |
There was a problem hiding this comment.
Uh, you are not supposed to call this script manually. It's supposed to be called by cmake. When releasing a new version, you update the version number in the CMakeLists.txt and run cmake, which will update the version everywhere. At least that's how I understand it's supposed to be done.
There was a problem hiding this comment.
Yes, that's correct. And failing to do so should fail travis.
There was a problem hiding this comment.
@GrayHatter what I'm trying to say here is that you should remove these 4 lines you have added and it should be good to go.
If you want to be extra careful, you could discard all the changes you have made in this PR, update the version number in cmake and let cmake call the version sync script to update everything.
|
Wait... So cmake is now a dependency for autotools? Lolwut Okay I'll fix it tonight. Anyone else can feel free to beat me |
|
No, cmake is not a dependency. The source of truth for the version number is in the cmake file, but that is only relevant when changing the number. |
|
Reviewed 4 of 4 files at r1. Comments from Reviewable |
iphydf
added
refactor
This change is