Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assoc #242

Merged
merged 1 commit into from
Nov 6, 2016
Merged

Remove assoc #242

merged 1 commit into from
Nov 6, 2016

Conversation

jhert0
Copy link
Member

@jhert0 jhert0 commented Nov 5, 2016

This change is Reviewable

@iphydf
Copy link
Member

iphydf commented Nov 5, 2016

Also remove the option from other/travis/toxcore-script.

@iphydf
Copy link
Member

iphydf commented Nov 5, 2016

:lgtm:


Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf self-assigned this Nov 5, 2016
@iphydf iphydf added this to the v0.0.3 milestone Nov 5, 2016
@nurupo
Copy link
Member

nurupo commented Nov 6, 2016

I grepped the repository to see if all assoc things were removed and apparently there are variables called assoc4 and assoc6 in the DHT.h, but they were added before any assoc.[c|h] existed and seem to be used just to store IP addresses 9de2953, i.e. irrelevant to the assoc we are trying to remove.

@nurupo
Copy link
Member

nurupo commented Nov 6, 2016

:lgtm_strong:


Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Nov 6, 2016

@endoffile78 can you rebase this and fix the conflict? (Sorry about that)

@iphydf
Copy link
Member

iphydf commented Nov 6, 2016

:lgtm_strong:


Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf iphydf merged commit 3f53090 into TokTok:master Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants