-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android build to CI. #459
Conversation
solves #340 |
This is insanely ugly, but it seems to work, so . We can clean up this CI script later. Please squash your commits into one. Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
Reviewed 2 of 2 files at r1. Comments from Reviewable |
can u squash em for me please? i checked that checkbox. |
also are you sure about that: EPOLLRDHUP fix? is that working for all platforms? |
I am not sure about it, but it seems to work, and we'll replace that with libev at some point anyway, so right now I don't care much. |
Fixes TokTok#340 Fixes TokTok#457
@iphydf funny that you call it insanely ugly :-) since those are your EXACT commands :-) (from jvm-toxcore-c repo). just not hidden in perl wrappers. |
c25a379
to
287a29b
Compare
jvm-toxcore-c scripts are also insanely ugly. |
i am happy they exist |
also include fix for #457
This change is