Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace include(CTest) on enable_testing() #576

Merged
merged 1 commit into from Sep 15, 2017

Conversation

Diadlo
Copy link

@Diadlo Diadlo commented Aug 6, 2017

CTest include generate a lot of unused targets

See here


This change is Reviewable

@robinlinden robinlinden added this to the v0.1.11 milestone Aug 6, 2017
@sudden6
Copy link

sudden6 commented Aug 11, 2017

:lgtm_strong:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@iphydf
Copy link
Member

iphydf commented Sep 13, 2017

Can you rebase on master (and/or click the checkbox)?

@Diadlo
Copy link
Author

Diadlo commented Sep 14, 2017

@iphydf Done

CTest include generate a lot of unused targets
@iphydf iphydf merged commit 7077662 into TokTok:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants