Fix linking with address sanitizer. #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
complete! 1 of 1 LGTMs obtained`-fsanitize=address` also needs to be passed to the linker.
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Sep 5, 2018
v0.2.3 **Merged PRs:** - [TokTok#951] Only run astyle if the astyle binary exists. - [TokTok#950] Remove utils.c and utils.h from toxencryptsave build. - [TokTok#949] Fixes to the imported sodium sources to compile without warnings. - [TokTok#948] Add a MAX_HOSTNAME_LENGTH constant. - [TokTok#947] Remove the format test. - [TokTok#937] Add new Circle CI configuration. - [TokTok#935] Add a test for double conference invite. - [TokTok#933] Add Logger to various net_crypto functions, and add `const` to Logger where possible. - [TokTok#931] Avoid conditional-uninitialised warning for tcp test. - [TokTok#930] Disable UDP when proxy is enabled. - [TokTok#928] Use clang-format for C++ code. - [TokTok#927] Add assertions to bootstrap tests for correct connection type. - [TokTok#926] Make NULL options behave the same as default options. - [TokTok#925] Add tests for what happens when passing an invalid proxy host. - [TokTok#924] Make the net_crypto connection state an enum. - [TokTok#922] Clarify/Improve test_some test - [TokTok#921] Beginnings of a TCP_test.c overhaul - [TokTok#920] Add test for creating multiple conferences in one tox. - [TokTok#918] Merge irungentoo/master into toktok - [TokTok#917] Add random testing program. - [TokTok#916] Fix linking with address sanitizer. - [TokTok#915] Remove resource_leak_test. - [TokTok#914] Make dht_test more stable. - [TokTok#913] Minor cleanup: return early on error condition. - [TokTok#906] Sort bazel build file according to buildifier standard. - [TokTok#905] In DEBUG mode, make toxcore crash on signed integer overflow. - [TokTok#902] Log only the filename, not the full path in LOGGER. - [TokTok#899] Fix macOS macro because of GNU Mach - [TokTok#898] Fix enumeration of Crypto_Connection instances - [TokTok#897] Fix ipport_isset: port 0 is not a valid port. - [TokTok#894] Fix logging related crash in bootstrap node - [TokTok#893] Fix bootstrap crashes, still - [TokTok#892] Add empty logger to DHT bootstrap daemons. - [TokTok#887] Fix FreeBSD build on Travis - [TokTok#884] Fix the often call of event tox_friend_connection_status - [TokTok#883] Make toxcore compile on BSD - [TokTok#878] fix DHT_bootstrap key loading - [TokTok#877] Add minitox to under "Other resources" section in the README - [TokTok#875] Make bootstrap daemon use toxcore's version - [TokTok#867] Improve network error reporting on Windows - [TokTok#841] Only check full rtp offset if RTP_LARGE_FRAME is set - [TokTok#823] Finish @Diadlo's network Family abstraction. - [TokTok#822] Move system header includes from network.h to network.c
iphydf
added a commit
to iphydf/c-toxcore
that referenced
this pull request
Sep 5, 2018
v0.2.3 **Merged PRs:** - [TokTok#951] Only run astyle if the astyle binary exists. - [TokTok#950] Remove utils.c and utils.h from toxencryptsave build. - [TokTok#949] Fixes to the imported sodium sources to compile without warnings. - [TokTok#948] Add a MAX_HOSTNAME_LENGTH constant. - [TokTok#947] Remove the format test. - [TokTok#937] Add new Circle CI configuration. - [TokTok#935] Add a test for double conference invite. - [TokTok#933] Add Logger to various net_crypto functions, and add `const` to Logger where possible. - [TokTok#931] Avoid conditional-uninitialised warning for tcp test. - [TokTok#930] Disable UDP when proxy is enabled. - [TokTok#928] Use clang-format for C++ code. - [TokTok#927] Add assertions to bootstrap tests for correct connection type. - [TokTok#926] Make NULL options behave the same as default options. - [TokTok#925] Add tests for what happens when passing an invalid proxy host. - [TokTok#924] Make the net_crypto connection state an enum. - [TokTok#922] Clarify/Improve test_some test - [TokTok#921] Beginnings of a TCP_test.c overhaul - [TokTok#920] Add test for creating multiple conferences in one tox. - [TokTok#918] Merge irungentoo/master into toktok - [TokTok#917] Add random testing program. - [TokTok#916] Fix linking with address sanitizer. - [TokTok#915] Remove resource_leak_test. - [TokTok#914] Make dht_test more stable. - [TokTok#913] Minor cleanup: return early on error condition. - [TokTok#906] Sort bazel build file according to buildifier standard. - [TokTok#905] In DEBUG mode, make toxcore crash on signed integer overflow. - [TokTok#902] Log only the filename, not the full path in LOGGER. - [TokTok#899] Fix macOS macro because of GNU Mach - [TokTok#898] Fix enumeration of Crypto_Connection instances - [TokTok#897] Fix ipport_isset: port 0 is not a valid port. - [TokTok#894] Fix logging related crash in bootstrap node - [TokTok#893] Fix bootstrap crashes, still - [TokTok#892] Add empty logger to DHT bootstrap daemons. - [TokTok#887] Fix FreeBSD build on Travis - [TokTok#884] Fix the often call of event tox_friend_connection_status - [TokTok#883] Make toxcore compile on BSD - [TokTok#878] fix DHT_bootstrap key loading - [TokTok#877] Add minitox to under "Other resources" section in the README - [TokTok#875] Make bootstrap daemon use toxcore's version - [TokTok#867] Improve network error reporting on Windows - [TokTok#841] Only check full rtp offset if RTP_LARGE_FRAME is set - [TokTok#823] Finish @Diadlo's network Family abstraction. - [TokTok#822] Move system header includes from network.h to network.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-fsanitize=addressalso needs to be passed to the linker.This change is