Use named function types for friend_requests callbacks. #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudden6
requested changes
Jul 8, 2018
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: 0 of 1 LGTMs obtained
toxcore/friend_requests.c, line 35 at r1 (raw file):
#include "util.h" #define MAX_RECEIVED_STORED 32
by moving this define it lost the context to the comment
toxcore/friend_requests.c, line 45 at r1 (raw file):
filter_function_cb *filter_function; void *filter_function_userdata; /* NOTE: The following is just a temporary fix for the multiple friend requests received at the same time problem.
here
iphydf
commented
Jul 8, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained
toxcore/friend_requests.c, line 35 at r1 (raw file):
Previously, sudden6 wrote…
by moving this define it lost the context to the comment
Done.
toxcore/friend_requests.c, line 45 at r1 (raw file):
Previously, sudden6 wrote…
here
Done.
sudden6
approved these changes
Jul 8, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! 1 of 1 LGTMs obtained
iphydf
force-pushed
the
fr-cb-types
branch
4 times, most recently
from
4e730f1
to
00676ea
Compare
Also: * `#define` must be scoped. If it's used outside a scope, it must be defined outside that scope (global `#define` does not need a matching `#undef`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
#definemust be scoped. If it's used outside a scope, it must bedefined outside that scope (global
#definedoes not need a matching#undef).This change is