Skip to content

Commit

Permalink
Reference follow up github issues in TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Tom-Newton committed Oct 18, 2023
1 parent 26d425e commit 13c0d1c
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions cpp/src/arrow/filesystem/azurefs_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class TestAzureFileSystem : public ::testing::Test {

void UploadLines(const std::vector<std::string>& lines, const char* path_to_file,
int total_size) {
// TODO: Switch to using Azure filesystem to write once its implemented.
// TODO(GH-38333): Switch to using Azure filesystem to write once its implemented.
auto blob_client = service_client_->GetBlobContainerClient(PreexistingContainerName())
.GetBlockBlobClient(path_to_file);
std::string all_lines = std::accumulate(lines.begin(), lines.end(), std::string(""));
Expand Down Expand Up @@ -247,7 +247,7 @@ TEST_F(TestAzureFileSystem, OpenInputStreamStringBuffers) {
}

TEST_F(TestAzureFileSystem, OpenInputStreamInfo) {
// TODO: When implemented use ASSERT_OK_AND_ASSIGN(info,
// TODO(GH-38335): When implemented use ASSERT_OK_AND_ASSIGN(info,
// fs->GetFileInfo(PreexistingObjectPath()));
arrow::fs::FileInfo info(PreexistingObjectPath(), FileType::File);

Expand Down Expand Up @@ -277,12 +277,12 @@ TEST_F(TestAzureFileSystem, OpenInputStreamNotFound) {
}

TEST_F(TestAzureFileSystem, OpenInputStreamInfoInvalid) {
// TODO: When implemented use ASSERT_OK_AND_ASSIGN(info,
// TODO(GH-38335): When implemented use ASSERT_OK_AND_ASSIGN(info,
// fs->GetFileInfo(PreexistingBucketPath()));
arrow::fs::FileInfo info(PreexistingContainerPath(), FileType::Directory);
ASSERT_RAISES(IOError, fs_->OpenInputStream(info));

// TODO: When implemented use ASSERT_OK_AND_ASSIGN(info,
// TODO(GH-38335): When implemented use ASSERT_OK_AND_ASSIGN(info,
// fs->GetFileInfo(NotFoundObjectPath()));
arrow::fs::FileInfo info2(PreexistingContainerPath(), FileType::NotFound);
ASSERT_RAISES(IOError, fs_->OpenInputStream(info2));
Expand All @@ -308,8 +308,8 @@ TEST_F(TestAzureFileSystem, OpenInputStreamReadMetadata) {

std::shared_ptr<const KeyValueMetadata> actual;
ASSERT_OK_AND_ASSIGN(actual, stream->ReadMetadata());
// TODO(GH-38330): This is asserting that the user defined metadata is returned but this is
// probably not the correct behaviour.
// TODO(GH-38330): This is asserting that the user defined metadata is returned but this
// is probably not the correct behaviour.
ASSERT_OK_AND_EQ("value0", actual->Get("key0"));
}

Expand Down Expand Up @@ -413,7 +413,7 @@ TEST_F(TestAzureFileSystem, OpenInputFileIoContext) {
}

TEST_F(TestAzureFileSystem, OpenInputFileInfo) {
// TODO: When implemented use ASSERT_OK_AND_ASSIGN(info,
// TODO(GH-38335): When implemented use ASSERT_OK_AND_ASSIGN(info,
// fs->GetFileInfo(PreexistingObjectPath()));
arrow::fs::FileInfo info(PreexistingObjectPath(), FileType::File);

Expand All @@ -434,12 +434,12 @@ TEST_F(TestAzureFileSystem, OpenInputFileNotFound) {
}

TEST_F(TestAzureFileSystem, OpenInputFileInfoInvalid) {
// TODO: When implemented use ASSERT_OK_AND_ASSIGN(info,
// TODO(GH-38335): When implemented use ASSERT_OK_AND_ASSIGN(info,
// fs->GetFileInfo(PreexistingContainerPath()));
arrow::fs::FileInfo info(PreexistingContainerPath(), FileType::File);
ASSERT_RAISES(IOError, fs_->OpenInputFile(info));

// TODO: When implemented use ASSERT_OK_AND_ASSIGN(info,
// TODO(GH-38335): When implemented use ASSERT_OK_AND_ASSIGN(info,
// fs->GetFileInfo(NotFoundObjectPath()));
arrow::fs::FileInfo info2(NotFoundObjectPath(), FileType::NotFound);
ASSERT_RAISES(IOError, fs_->OpenInputFile(info2));
Expand Down

0 comments on commit 13c0d1c

Please sign in to comment.