Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #180

Merged
merged 4 commits into from
Jun 1, 2022
Merged

Cleanup #180

merged 4 commits into from
Jun 1, 2022

Conversation

OmerShoulstein
Copy link
Collaborator

No description provided.

@OmerShoulstein OmerShoulstein added cleanup Internal code refactoring draft Under constructions labels Jun 1, 2022
@OmerShoulstein OmerShoulstein added this to the Web Server + API milestone Jun 1, 2022
@OmerShoulstein OmerShoulstein linked an issue Jun 1, 2022 that may be closed by this pull request
Remove use of Type field in Message class #178
Closed
TomBenDor
TomBenDor previously approved these changes Jun 1, 2022
View reviewed changes
@Tom-stack3 Tom-stack3 changed the title cleanup Cleanup Jun 1, 2022
@OmerShoulstein @Tom-stack3 @apBIU2022
Send and receive messages in real time (#177)
53f64f3 
* Added signalR to project

* Fixed signalr

* Added basic hub

* Added temporary signalR connection code

* Capitalize directory name

* Fix bug in CORS

* SginalR adds messages to clients

* Messages and contact invitations are sent in real time

Co-authored-by: Tommy <Tom-stack3@users.noreply.github.com>
Co-authored-by: AP-BIU <apBIU2022@users.noreply.github.com>
Tom-stack3
Tom-stack3 previously approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mr. Clean

@OmerShoulstein OmerShoulstein removed the draft Under constructions label Jun 1, 2022
@TomBenDor TomBenDor dismissed stale reviews from Tom-stack3 and themself via c21f7ff June 1, 2022 17:35
Tom-stack3
Tom-stack3 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@Tom-stack3 Tom-stack3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mr. Clean fr

@TomBenDor TomBenDor self-requested a review June 1, 2022 19:00
TomBenDor
TomBenDor approved these changes Jun 1, 2022
View reviewed changes
Copy link
Owner

@TomBenDor TomBenDor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's clean

@Tom-stack3 Tom-stack3 merged commit 1b5a738 into milestone-2 Jun 1, 2022
@Tom-stack3 Tom-stack3 deleted the 178-remove-use-of-type-field-in-message-class branch June 1, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomBenDor TomBenDor TomBenDor approved these changes

@Tom-stack3 Tom-stack3 Tom-stack3 approved these changes

Assignees
No one assigned
Labels
cleanup Internal code refactoring
Projects
None yet
Milestone
Web Server + API
Development

Successfully merging this pull request may close these issues.

Remove use of Type field in Message class
3 participants
@OmerShoulstein @TomBenDor @Tom-stack3