issues/100 Composition #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I went back to classes so that the constructor would be hidden, but records implement equals and hashCode by default, so I'm just going to use records. We can conider hiding the default constructor later, it might not really be that big an issue.
Tomboyo
commented
Oct 15, 2023
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/icg/OasSchemaToAst.java
Show resolved
Hide resolved
Tomboyo
commented
Oct 19, 2023
modules/lily-compiler/src/main/java/io/github/tomboyo/lily/compiler/icg/OasSchemaToAst.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in basic support for components. Our models will now generate builders and getter APIs per ADR 0002, but don't yet handle sealed interface types for overloaded properties. Mandatory properties are (fully?) supported in the PR.
closes #100