Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(syntax): fix deprecated actions syntax. Fixes #566 #699

Merged

Conversation

altmas5
Copy link
Contributor

@altmas5 altmas5 commented Aug 4, 2023

Description

Remove usage of set-output on the Github Actions Workflows

Describe what you did and why.

I followed the specs on the issue with the help wanted label

Related issue (if any): fixes #556

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

@altmas5 altmas5 requested a review from TomerFi as a code owner August 4, 2023 17:16
@welcome
Copy link

welcome bot commented Aug 4, 2023

Thanks for opening this pull request! Please check out our contributing guidelines.

@pull-request-size pull-request-size bot added the size: xs Pull request has less then 10 lines label Aug 4, 2023
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Aug 4, 2023
@TomerFi TomerFi linked an issue Aug 4, 2023 that may be closed by this pull request
@TomerFi TomerFi enabled auto-merge (squash) August 4, 2023 20:14
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #699 (30443ed) into dev (b91385c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #699   +/-   ##
=======================================
  Coverage   97.66%   97.66%           
=======================================
  Files           1        1           
  Lines         171      171           
=======================================
  Hits          167      167           
  Misses          4        4           

@TomerFi TomerFi merged commit 561e918 into TomerFi:dev Aug 4, 2023
7 checks passed
@welcome
Copy link

welcome bot commented Aug 4, 2023

Congrats on merging your first pull request! Your contribution is highly appriciated!

@auto-me-bot auto-me-bot bot added status: approved Pull request is approved status: merged Pull request merged and removed status: needs review Pull request needs a review labels Aug 4, 2023
@TomerFi
Copy link
Owner

TomerFi commented Aug 7, 2023

@allcontributors add @altmas5 for ci

@allcontributors
Copy link
Contributor

@TomerFi

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@TomerFi
Copy link
Owner

TomerFi commented Aug 7, 2023

@allcontributors add @altmas5 for infra

@allcontributors
Copy link
Contributor

@TomerFi

I've put up a pull request to add @altmas5! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request has less then 10 lines status: approved Pull request is approved status: merged Pull request merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github set-output deprecation notice
2 participants